OAK-11975: Use Mockito as an agent in Oak #2653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the dynamic inline mocking with a static agent dependency.
Contributor
Author
|
The surefire und failsafe configs are part of the parent pom so that they are reused in all subproject. I left it that way, which has the slightly ugly side effect that the agent is used even in projects that do not use mockito, which now need a mockito-core dependency. Of course, we can also decide to leave the parent pom unchanged and override the config in the subprojects that actually use mockito. I prefer the parent pom solution, which produces much less boilerplate and automatically makes all subprojects mockito ready. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the dynamic inline mocking with a static agent dependency.